[SYCL][E2E][Joint Matrix] New test transpose A and B #16684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
jm_colmajor_ab_store_test
branch
from
b7f10de to
d35cb0b
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
jm_colmajor_ab_store_test
branch
from
2843979 to
e49af63
Compare
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
reviewed
Jan 28, 2025
| #include "common.hpp" | ||
| #include <sycl/usm.hpp> | ||
|
|
||
| template <typename T, size_t TileRows, size_t TileCols> class MT; |
There was a problem hiding this comment.
should "use" be added to the template as well as we may have the three to be the same for both a and b matrices (like 16x16x16 combinations)?
There was a problem hiding this comment.
I prefer not to add something that is not used currently. It is easy to extend, when it is needed.
| bool int8_run = false; | ||
|
|
||
| for (auto &combination : combinations) { | ||
| if (!bf16_run && combination.atype == matrix_type::bf16) { |
There was a problem hiding this comment.
we should add the big combinations as well.
If these are not supported yet, comment them out and add jira in the comment.
There was a problem hiding this comment.
I plan to add them later in the next PRs, when I start working on them in IGC.
|
@intel/llvm-gatekeepers , all green, please, merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.